Skip to content

Use the maintainers membership type for organization teams.#473

Merged
Stormheg merged 2 commits intomainfrom
org-teams-use-maintainers
Apr 21, 2026
Merged

Use the maintainers membership type for organization teams.#473
Stormheg merged 2 commits intomainfrom
org-teams-use-maintainers

Conversation

@tim-schilling
Copy link
Copy Markdown
Member

This avoids the cycling of membership state between GitHub and Terraform.

This should resolve the issue we see in the plans from the last 2 PRs:

@tim-schilling tim-schilling requested a review from a team as a code owner April 17, 2026 12:43
@cunla
Copy link
Copy Markdown
Member

cunla commented Apr 17, 2026

Terraform plan for members

Plan: 0 to add, 1 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place

Terraform will perform the following actions:

  # github_team_members.org_team_members["Admins"] will be updated in-place
!~  resource "github_team_members" "org_team_members" {
        id      = "9763562"
#        (1 unchanged attribute hidden)

-       members {
-           role     = "member" -> null
-           username = "Daksh777" -> null
        }
-       members {
-           role     = "member" -> null
-           username = "TildaDares" -> null
        }
-       members {
-           role     = "member" -> null
-           username = "bckohan" -> null
        }
+       members {
+           role     = "maintainer"
+           username = "Daksh777"
        }
+       members {
+           role     = "maintainer"
+           username = "TildaDares"
        }
+       members {
+           role     = "maintainer"
+           username = "bckohan"
        }

#        (5 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

✅ Plan applied in Apply org membership changes #34

Outputs
invalid_users = []

This avoids the cycling of membership state between GitHub and
Terraform.
@tim-schilling tim-schilling force-pushed the org-teams-use-maintainers branch from 912c99b to 8079f31 Compare April 17, 2026 12:50
@Stormheg
Copy link
Copy Markdown
Member

This makes the new admins maintainers instead of members. Is that expected?

@tim-schilling
Copy link
Copy Markdown
Member Author

Yes, I changed the code back to match our original policy which was to have these org teams allow people to manage the teams outside of terraform if needed. They shouldn't have to though.

@Stormheg Stormheg merged commit 655ee7b into main Apr 21, 2026
4 checks passed
@Stormheg Stormheg deleted the org-teams-use-maintainers branch April 21, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants